Skip to content

Conversation

@Basile-Terv
Copy link
Collaborator

@Basile-Terv Basile-Terv commented Jun 23, 2024

Lots of new config files were created and launched with python mila/launch_exp.py exp=xxxx.
The main changes in the code are the addition of the new module via the trainer scripts, the lmdb dataset script and the faenet.py script.
Will clean this branch and resubmit a PR.

  • Basile: change name of interactions_range.ipynb to remerge later in not_only_faenet
  • delete all that is relative to new task is2re_aux_to_is2re
  • delete print in base_trainer.py and single_trainer.py (ctrl+f breakpoints)
  • install blak extension and format save all modified scripts
  • Add comments to explain behavior of any new code
  • Add docstrings for new functions
  • Clean useless determ noise in lmdbnoisydataset
  • Comments about noising of positions in trainers and dataset
  • Théo: repasser sur data_transforms
  • Chaque xp du workshop paper doit etre relancee et mettre wandb links in the Readme of the PR to prove it still works.

@vict0rsch vict0rsch changed the base branch from main to not_only_faenet July 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants