Fix fire detection backend selection and simplify return type handling #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied code review feedback from PR #356. Fire detection logic was checking
backend == "auto"but_get_detection_backend()only returns"local","huggingface", orNone, causing fire detection to be skipped when local backend was selected even with HF fallback available.Changes:
backend == "huggingface" or (backend == "local" and ENABLE_HF_FALLBACK)to properly enable HF fallback from local modedetect_fire_clipconsistently returnsList[Dict]💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Summary by cubic
Fixes SPA navigation glitches and corrects fire detection backend selection with HF fallback. Streamlines backend flow to make page transitions smooth and reduce server work.
Bug Fixes
Refactors
Written for commit 8b8d281. Summary will update on new commits.