Open
Conversation
Owner
|
Thanks for your PR! It's going to take me some time to review... There's a lot going on here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through the entire code in order to understand it and added some comments along the way. I also got rid of a few debug logs to make the code more readable.
I separated what I considered to be the core internal functions of the application from the rest of the code into separate files before refactoring the entire core UI architecture. This refactoring added the use of a view dispatcher and a scene manager, which enable the creation of advanced interfaces: https://developer.flipper.net/flipperzero/doxygen/js_gui.html#autotoc_md282