Skip to content

fix: improve password visibility toggle a11y#2008

Open
remove334 wants to merge 1 commit into
RocketChat:mainfrom
remove334:fix/password-input-toggle-a11y
Open

fix: improve password visibility toggle a11y#2008
remove334 wants to merge 1 commit into
RocketChat:mainfrom
remove334:fix/password-input-toggle-a11y

Conversation

@remove334

Copy link
Copy Markdown

Summary

  • gives the password visibility toggle an accessible name, button role, pressed state, and keyboard handling
  • prevents toggling when the input is disabled
  • adds coverage for mouse and keyboard visibility toggling

Test plan

  • git diff --check
  • yarn workspace "@rocket.chat/fuselage" test PasswordInput.spec.tsx --runInBand could not run because the repository has no local node_modules state file in this environment.

@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f6aaa9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


cqh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants