fix(fuselage): remove flicker in closing animations in MultiSelect and AutoComplete components#1888
Open
vmridul wants to merge 2 commits intoRocketChat:mainfrom
Open
fix(fuselage): remove flicker in closing animations in MultiSelect and AutoComplete components#1888vmridul wants to merge 2 commits intoRocketChat:mainfrom
vmridul wants to merge 2 commits intoRocketChat:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 0ae9b1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Member
|
@vmridul can u add a changeset? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When closing the dropdown in MultiSelect and Autocomplete, there was a quick flicker at the end — the dropdown would flash back to fully visible for a split second before finally disappearing.
Root Cause
The exit animation itself was working fine and playing all the way through. The problem was happening right after the animation finished. The browser resets the element back to its original state. That brief reset is what caused the visible flicker.
Proposed changes (including videos or screenshots)
Added
animation-fill-mode: forwardstoAnimatedVisibility. This tells the browser to hold the final frame of the animation (fully hidden) instead of resetting back to visible.Affected Components
AutoComplete
MultiSelect
PaginatedMultiSelectFiltered
PaginatedSelectFiltered
Screen Recordings:
Before:
https://github.com/user-attachments/assets/1061d0fb-2a39-40cb-823c-eeba96ffb75c
After:
https://github.com/user-attachments/assets/2feb32f8-0b89-4bf2-9f82-098226c2ea79
Issue(s)
Further comments