Skip to content

fix(fuselage): prevent MultiSelect dropdown from reopening on toggle click #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DammyCodes-all wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −1
Open

fix(fuselage): prevent MultiSelect dropdown from reopening on toggle click #1870

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d66022
feat(MultiSelect): enhance click handling to manage visibility state …
DammyCodes-all Feb 26, 2026
5abedf6
Merge branch 'main' into aluminate
DammyCodes-all Feb 26, 2026
4a57f90
Merge branch 'main' into aluminate
DammyCodes-all Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/fuselage/src/components/MultiSelect/MultiSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ const MultiSelect = forwardRef<HTMLInputElement, MultiSelectProps>(
useEffect(reset, [filter]);

const innerRef = useRef<HTMLElement>(null);
const wasVisibleOnMouseDownRef = useRef(false);
const anchorRef = useMergedRefs(ref, innerRef);

const { ref: containerRef, borderBoxSize } = useResizeObserver();
Expand All @@ -136,8 +137,18 @@ const MultiSelect = forwardRef<HTMLInputElement, MultiSelectProps>(
return null;
};

const handleMouseDown = useStableCallback(() => {
wasVisibleOnMouseDownRef.current = visible === AnimatedVisibility.VISIBLE;
});

const handleClick = useStableCallback(() => {
if (visible === AnimatedVisibility.VISIBLE) {
const shouldHide =
wasVisibleOnMouseDownRef.current ||
visible === AnimatedVisibility.VISIBLE;

wasVisibleOnMouseDownRef.current = false;

if (shouldHide) {
return hide();
}
innerRef.current?.focus();
Expand All @@ -150,6 +161,7 @@ const MultiSelect = forwardRef<HTMLInputElement, MultiSelectProps>(
rcx-select
className={[error && 'invalid', disabled && 'disabled']}
ref={containerRef}
onMouseDown={handleMouseDown}
onClick={handleClick}
disabled={disabled}
{...props}
Expand Down