Skip to content

fix: use updater for username update to ensure transactional consistency #39955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gauravsingh001-cyber wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −3
Open

fix: use updater for username update to ensure transactional consistency #39955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions apps/meteor/app/lib/server/functions/setUsername.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,22 @@ export const _setUsername = async function (
}, session);
}
// Set new username*
// TODO: use updater for setting the username and handle possible side effects in addUserToRoom
await Users.setUsername(user._id, username, { session });
user.username = username;

if (updater) {
await updater.updateOne(
{ _id: user._id },
{ $set: { username } }
);
} else {

await Users.updateOne(
{ _id: user._id },
{ $set: { username } },
{ session }
);
}

user.username = username;

if (!previousUsername && settings.get('Accounts_SetDefaultAvatar') === true) {
const avatarSuggestions = await getAvatarSuggestionForUser(user);
Expand Down