Skip to content

fix: improve grammar for 'Add topic' text#39947

Open
bhoomi-sahu wants to merge 2 commits intoRocketChat:developfrom
bhoomi-sahu:fix-add-topic-text
Open

fix: improve grammar for 'Add topic' text#39947
bhoomi-sahu wants to merge 2 commits intoRocketChat:developfrom
bhoomi-sahu:fix-add-topic-text

Conversation

@bhoomi-sahu
Copy link
Copy Markdown

@bhoomi-sahu bhoomi-sahu commented Mar 29, 2026

Description

Improved the grammar of the "Add topic" text.

Changes

  • Updated "Add topic" to "Add a topic" for better readability

Impact

Enhances clarity and improves user experience.

Notes

  • No changes to translation keys
  • Only updated text value

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced the loading screen's accessibility label to provide clearer feedback for screen reader users.

@bhoomi-sahu bhoomi-sahu requested a review from a team as a code owner March 29, 2026 12:25
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Mar 29, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 29, 2026

⚠️ No Changeset found

Latest commit: 6f9cf60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5dde1ba3-15d9-4781-b988-270ac722e24d

📥 Commits

Reviewing files that changed from the base of the PR and between 4235cd9 and a26a3b5.

📒 Files selected for processing (1)
  • apps/meteor/client/views/root/PageLoading.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: cubic · AI code reviewer
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

  • apps/meteor/client/views/root/PageLoading.tsx
🧠 Learnings (2)
📚 Learning: 2026-02-24T19:36:55.089Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/page-objects/fragments/home-content.ts:60-82
Timestamp: 2026-02-24T19:36:55.089Z
Learning: In RocketChat/Rocket.Chat e2e tests (apps/meteor/tests/e2e/page-objects/fragments/home-content.ts), thread message preview listitems do not have aria-roledescription="message", so lastThreadMessagePreview locator cannot be scoped to messageListItems (which filters for aria-roledescription="message"). It should remain scoped to page.getByRole('listitem') or mainMessageList.getByRole('listitem').

Applied to files:

  • apps/meteor/client/views/root/PageLoading.tsx
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.

Applied to files:

  • apps/meteor/client/views/root/PageLoading.tsx
🔇 Additional comments (1)
apps/meteor/client/views/root/PageLoading.tsx (1)

4-4: Looks good — accessibility label update is clear and safe.

This is a clean, non-functional text improvement and does not introduce behavior or a11y regressions.


Walkthrough

Updated the aria-label attribute value in the page loading component from 'loading' to 'Loading...' for improved accessibility. This is a single-file, text-only modification with no changes to logic, structure, or component behavior.

Changes

Cohort / File(s) Summary
Accessibility Label Update
apps/meteor/client/views/root/PageLoading.tsx
Updated aria-label text from 'loading' to 'Loading...' for better screen reader experience.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to improve grammar for 'Add topic' text, but the actual changeset updates the aria-label in PageLoading.tsx from 'loading' to 'Loading...' for accessibility purposes. Update the PR title to accurately reflect the actual changes, such as 'fix: improve loading aria-label for better accessibility' to match the commit message and actual file modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


bhoomi-sahu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants