Skip to content

fix: deeplinking fails to open group when group id is provided in link #7111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rohit3523 wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −2
Draft

fix: deeplinking fails to open group when group id is provided in link #7111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/lib/methods/canOpenRoom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ERoomTypes } from '../../definitions';
import database from '../database';
import sdk from '../services/sdk';
import { createDirectMessage } from '../services/restApi';
import { createDirectMessage, getRoomByTypeAndName } from '../services/restApi';

const restTypes = {
channel: 'channels',
Expand Down Expand Up @@ -29,9 +29,10 @@ async function open({ type, rid, name }: { type: ERoomTypes; rid: string; name:
// if it's a group we need to check if you can open
if (type === ERoomTypes.GROUP) {
try {
const result = await getRoomByTypeAndName('p', name);
// RC 0.61.0
// @ts-ignore
await sdk.post(`${restTypes[type]}.open`, params);
await sdk.post(`${restTypes[type]}.open`, { roomId: result._id });
} catch (e: any) {
if (!(e.data && /is already open/.test(e.data.error))) {
return false;
Expand Down
Loading