Skip to content

feat: Clicking Image in files aggregator now opens image Gallery#824

Closed
thepiyush-303 wants to merge 4 commits intoRocketChat:developfrom
thepiyush-303:feat/filesAggreator
Closed

feat: Clicking Image in files aggregator now opens image Gallery#824
thepiyush-303 wants to merge 4 commits intoRocketChat:developfrom
thepiyush-303:feat/filesAggreator

Conversation

@thepiyush-303
Copy link
Copy Markdown
Contributor

@thepiyush-303 thepiyush-303 commented Jan 6, 2025

Brief Title

Acceptance Criteria fulfillment

  • clicking image files opens image Gallery
  • clicking on other types of file download the file

Fixes #823

Video/Screenshots

Before:
Clicking does not do anything.
After:

Screencast.from.2025-01-07.00-44-23.2.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-824 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Copy Markdown
Collaborator

@thepiyush-303
Resolve conflicts and attach videos in mp4

@thepiyush-303
Copy link
Copy Markdown
Contributor Author

@Spiral-Memory
Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking Image in files aggregator opens image Gallery

2 participants