fix(auth): validate origin of oauth callback to prevent login csrf#1093
Merged
Spiral-Memory merged 1 commit intoRocketChat:developfrom Mar 21, 2026
Merged
Conversation
Collaborator
|
Could you create a video demonstrating that the functionality continues to operate as intended? |
Contributor
Author
|
Sure @Spiral-Memory ;) |
Contributor
Author
|
hi @Spiral-Memory i attached the video... let me know if you want anything else too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a critical security vulnerability in the OAuth login flow where the application accepted OAuth callback messages from any origin.
Previously, the
postMessageevent listener inloginWithRocketChatOAuthdid not validate the origin of incoming messages. This allowed malicious websites to forge OAuth callbacks and potentially force users to log in with attacker-controlled accounts.Closes #1071
Fix
event.originmatches the trusted Rocket.Chat server originconfig.api.baseUrlOnly messages from the configured Rocket.Chat server are now accepted.