Add tests, relax minimum required RubyLLM version to 1.5#8
Merged
toddkummer merged 4 commits intomainfrom Apr 23, 2026
Merged
Conversation
The goal here is to make sure changes to the Provider#complete method (or anything else) do not cause problems. This will allow me to relax the minimum required version.
This uses argument forwarding and splatting to capture and provide the arguments to the Provider#complete method. This should loosen the version requirements for the RubyLLM gem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added testing across RubyLLM versions and relaxed the minimum required version to 1.5, which goes back to July 2025.
In order to support across versions, the way arguments to the Provider#complete method are captured needed to be updated to handle different signatures.