Improve EEPROM naming and scan UX#3
Merged
Conversation
Release v0.3
…ary handling for .mpy files
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves HexManager’s startup warning UX and EEPROM scan/init flows, while also separating the HexManager UI display name from the EEPROM header friendly_name (to support “HexCurrent” in the UI while writing “HexCurent” into headers/notifications).
Changes:
- Added message wrapping + pagination for startup warnings (including preserving real import failure reasons).
- Added blank-EEPROM geometry probing + manual “Scan” UX, plus suppression of repeated init prompts after the user declines.
- Introduced vendored EEPROM apps (HexDrive2, HexCurrent) via submodules and updated build/deploy scripts and hexpansions metadata accordingly.
Reviewed changes
Copilot reviewed 13 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tildagon.toml | Bumps app version to 0.4. |
| app.py | Adds startup warning formatting, message wrapping/pagination, and improved import error reporting. |
| hexpansion_mgr.py | Adds EEPROM geometry detection, manual scan sub-state, init-decline tracking, and uses friendly_name for EEPROM headers. |
| hexpansions.json | Adds friendly_name, adds HexCurrent entry, and switches HexDriveV2 to hexdrive2 artifact/version. |
| README.md | Documents friendly_name semantics and constraints. |
| EEPROM/hexdrive.py | Introduces _MIN_BADGEOS_VERSION constant and uses it for version gating. |
| tests/test_smoke.py | Adds tests for warning pagination/import failure reporting and extends app version consistency checks to vendored sources. |
| tests/test_serialise.py | Adds tests for EEPROM geometry detection, scan UX, friendly_name handling, and init-decline behavior. |
| dev/download_to_device.py | Adds compilation/deploy of vendored HexDrive2/HexCurrent artifacts. |
| dev/build_release.py | Adds external module compilation and vendor-dir ignore logic for release packaging. |
| .gitmodules | Adds vendor submodules (HexDrive2, HexCurrent). |
| .gitignore | Stops ignoring *.mpy so compiled artifacts can be committed/packaged. |
| .github/workflows/release.yml | Updates Python setup action (but still needs submodule initialization for new vendor deps). |
| .gitattributes | Adjusts export-ignore rules and marks .mpy as binary for diffs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Robotmad/HexManager/sessions/3dbe6bc7-1ce8-409b-b5d5-2f9980a30c63 Co-authored-by: Robotmad <3315650+Robotmad@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Robotmad/HexManager/sessions/4248c750-a1c6-45b3-85ff-1a3980584125 Co-authored-by: Robotmad <3315650+Robotmad@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Removed checkout command for HexManager submodule.
Added a step to checkout the badge repository based on the PR branch.
Updated Python setup step to use a fixed version 3.11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namefrom EEPROM headerfriendly_nameHexCurrentin HexManager UI while writingHexCurentinto the EEPROM headerValidation
python -m py_compile sim/apps/HexManager/app.py sim/apps/HexManager/hexpansion_mgr.py sim/apps/HexManager/tests/test_serialise.py sim/apps/HexManager/tests/test_smoke.pyCOM7