Conversation
pkrack
requested changes
Dec 4, 2024
Collaborator
pkrack
left a comment
pkrack
left a comment
There was a problem hiding this comment.
Check that it works with the latest commit using the pip package. If it works remove the commented out lines in the toplevel CMakeLists.txt then merge
After testing that the pip installation works, the lines that install pinocchio with fetchcontent are removed.
Contributor
Author
|
The main reason to install C++ dependencies with pip is to avoid potential long compilation times. In the case of mujoco we also need their python bindings which need to be interchangable with other mujoco imports. The disadvantage, however, is that it breaks cmake compilations without pip (as the required binaries are located in the virtualenv folder). This is only a problem if we would want to distribute rcs as a C++ library which we currently do not plan to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.