-
-
Notifications
You must be signed in to change notification settings - Fork 70
Sync common files with ros-jazzy and ros-kilted #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
emscripten is failing with error: |
|
Probably we need to update the vinca version in |
After updating to the latest vinca, the logic in ros-humble/.github/workflows/main.yml Line 33 in 8d42564
linux.yml to linux64.yml in RoboStack/vinca@5f9a3cc . @Tobias-Fischer is the change in file name in vinca intentional?
|
|
Hmmm probably not .. happy to revert RoboStack/vinca@5f9a3cc |
Great, see RoboStack/vinca#109 . I think after that PR is merged I can update vinca again in this PR (and revert also 01d54f0). |
|
@Tobias-Fischer ready for review. Updating to RoboStack/vinca#110 would be a nice to have, but it is not blocking. |
|
While I was at it, I also cleanup up the latest occurences of |
|
Let’s incorporate RoboStack/vinca#110 |
I manually aligned files across ros-humble, ros-jazzy and ros-kilted repos (using the three-way directory diff in Meld).
This is just a workaround for RoboStack/robostack.github.io#22, but it was the quickest solution to re-align everything.
I also removed the workaround 01d54f0 as it is not needed after RoboStack/vinca#109 .