feat(frontend): add taproot PSBT signing utility for browser wallets#2432
Draft
joelklabo wants to merge 3 commits intoRoboSats:mainfrom
Draft
feat(frontend): add taproot PSBT signing utility for browser wallets#2432joelklabo wants to merge 3 commits intoRoboSats:mainfrom
joelklabo wants to merge 3 commits intoRoboSats:mainfrom
Conversation
8 tasks
Author
|
Hi @ReneSmeets @cryptosharks - checking in on this PR. It's ready to merge and implements the PSBT signer utilities for the bounty (600k sats). Let me know if any changes are needed! |
Author
|
Hi @ReneSmeets @cryptosharks - just checking in again. This PR is ready to merge and implements the PSBT signer utilities for the 600k sats bounty. Is there anything else needed from my side? Thanks! |
Author
|
Hi @ReneSmeets @cryptosharks - checking in again. This PR is mergeable and implements the PSBT signer utilities for the 600k sats bounty. Is there anything else needed to move this forward? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a frontend utility module for the Taproot escrow workstream in
#230, focused on the two integration pieces discussed in the issue thread:What Changed
frontend/src/utils/taproot.ts:generateTaprootKeypair()for deterministic/generated secret -> x-only pubkeyisLikelyPsbt()andnormalizePsbt()for base64/hex PSBT handlinggetBrowserPsbtSigner()for browser provider detection (unisat,okxwallet.bitcoin)signPsbtWithBrowserWallet()wrapper that signs via browser wallet and returns normalized base64 PSBTfrontend/src/utils/taproot.test.tsfrontend/src/utils/index.tsValidation
npm run lint -- src/utils/taproot.ts src/utils/taproot.test.ts src/utils/index.tsnpm test -- src/utils/taproot.test.ts --runInBandnpm run buildNotes