Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.

Conversation

@andrewyarovoi
Copy link
Contributor

@andrewyarovoi andrewyarovoi commented Sep 22, 2019

Description

This PR adds the master branch of the velodyne package as a sub module and enables the use of organized clouds to allow for more efficient calculation of normals.

This PR does the following:

  • Adds the Velodyne package as a submodule
  • Adds the option to enable organized clouds in velodyne_lidar.launch (false by default)

Fixes #508

Testing steps (If relevant)

  1. Connect to a Velodyne puck (http://wiki.ros.org/velodyne/Tutorials/Getting%20Started%20with%20the%20Velodyne%20VLP16)
  2. roslaunch igvc_platform velodyne_lidar.launch organize_cloud:="true"

Expectation: Should run normally.

Self Checklist

  • I have formatted my code using make format
  • I have tested that the new behaviour works

Copy link
Contributor

@oswinso oswinso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me, but we'll need to test first before merging

@oswinso
Copy link
Contributor

oswinso commented Sep 27, 2019

Oh woops Wednesday we had all hands + some other stuff so we couldn't get to test it out then. Let's aim for the coming Wednesday to test this.

@oswinso oswinso closed this Sep 27, 2019
@oswinso oswinso reopened this Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use latest velodyne package for organized cloud

3 participants