Fix SignInForm error handling and remove unused schedules pages#144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes error handling in the SignInForm component, improving how connectivity and authentication errors are surfaced to users. It also removes the unused ledger schedules pages and performs a subtree split of
src/lib/core/.Changes
🐛 Bug Fix: SignInForm Error Handling
SignInForm.tsxto properly catch and display connectivity issues (e.g., network failures, server unreachable) alongside standard authentication errors.SignInForm.test.tsxwith new test cases specifically targeting connectivity failure scenarios, ensuring error states render correctly and edge cases are handled.🗑️ Removed Unused Code
src/app/(app)/ledger/schedules/content.tsx(595 lines) and its correspondingpage.tsx— these ledger schedule pages were unused and removed as part of cleanup.🔧 Infrastructure
CLAUDE.mdwith minor configuration changes.src/lib/core/into a separate commit for repository organization purposes.Key UI/UX Improvements
Breaking Changes
/ledger/schedulesroute and all associated components have been deleted. If any navigation links or references point to this route, they will result in a 404. Verify no active features depend on these pages.Testing Notes for Reviewers
npm test -- SignInForm.test.tsx— verify all new connectivity error test cases pass./ledger/schedulesreturns a 404 or redirects appropriately.Browser Compatibility Considerations
🤖 Generated with Claude Code
Branch Info:
bugfix/login-fixmainCo-Authored-By: Claude noreply@anthropic.com