Add pre-commit CI notes #334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently undocumented that you need `pyright[nodejs]` for Pre-commit CI. Additional config information for dealing with CI vs local environments would be helpful.
This was referenced Feb 26, 2025
Owner
|
Thanks for the PR, I no longer use pre-commit but I'm surprised that the |
Author
|
Here's an example failure: https://results.pre-commit.ci/run/github/45885732/1740541637.q4fPhjtFQSSYzUN6dMf2nw The default |
Author
|
I think the issue here also documents this #345 I've also realised my solution in this PR might not be working either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently undocumented that you need
pyright[nodejs]for Pre-commit CI.Additional config information for dealing with CI vs local environments would be helpful.