Fix --meta argument help text and default in hydro CLI#1268
Open
ecopony wants to merge 2 commits intoRiverscapes:devfrom
Open
Fix --meta argument help text and default in hydro CLI#1268ecopony wants to merge 2 commits intoRiverscapes:devfrom
ecopony wants to merge 2 commits intoRiverscapes:devfrom
Conversation
Use computed temp_folder variable instead of args.temp_folder in non-debug code path. When the flag is omitted, args.temp_folder is None, but temp_folder defaults to output_dir/temp.
The default value of '{}' would cause parse_metadata() to fail when --meta was not provided. Updated help text to correctly describe the expected format: comma-separated key=value pairs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix --meta argument default and help text in hydro CLI
Problem
The default value of
'{}'causedparse_metadata()to fail when--metawas not provided:Exception: Error parsing command line metadata: {}
The function expects comma-separated
key=valuepairs, not JSON.Fix