Skip to content

DEV-118464 fix xss vulnerability #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beksina wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DEV-118464 fix xss vulnerability #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb3112a
fix xss vulnerability in notification server samples
beksina Dec 23, 2025
a5efcea
tweak
beksina Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...e/src/main/java/com/riskified/samples/notificationServer/servlet/NotificationServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,26 @@ public NotificationServlet(String authKey) throws RiskifiedError {
formatter = new NotificationHandler(authKey);
}

private static String escapeHtml(String input) {
if (input == null) {
return "";
}
return input
.replace("&", "&")
.replace("<", "&lt;")
.replace(">", "&gt;");
}

protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws ServletException,
IOException {
PrintWriter out = resp.getWriter();
try {
NotificationOrder notification = formatter.parseServletPostRequest(req).getOrder();
System.out.println("got notification for id: '" + notification.getId() + "' with status: '" + notification.getStatus() +"' ");
out.println("<HTML><BODY>Merchant Received Notification For Order " + notification.getId()
+ " with status " + notification.getStatus() + " and description " + notification.getDescription()
+ " and app_dom_id " + notification.getCustom().getAppDomId()
+ " Old Status was " + notification.getOldStatus()
out.println("<HTML><BODY>Merchant Received Notification For Order " + escapeHtml(notification.getId())
+ " with status " + escapeHtml(notification.getStatus()) + " and description " + escapeHtml(notification.getDescription())
+ " and app_dom_id " + escapeHtml(notification.getCustom().getAppDomId())
+ " Old Status was " + escapeHtml(notification.getOldStatus())
+ "</BODY></HTML>");

} catch (Exception e) {
Expand Down
16 changes: 13 additions & 3 deletions ...-sample/src/main/java/com/riskified/samples/notificationServer/socket/HTTPPOSTServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ public void run() {
}
NotificationHandler formatter = new NotificationHandler("26faa0eb6eacf889e300944c297640b68789b11c");
NotificationOrder notification = formatter.toObject(body, hash).getOrder();
sendResponse(200, "<HTML><BODY>Merchant Received Notification For Order " + notification.getId()
+ " with status " + notification.getStatus() + " and description " + notification.getDescription()
+ " Old Status was " + notification.getOldStatus()
sendResponse(200, "<HTML><BODY>Merchant Received Notification For Order " + escapeHtml(notification.getId())
+ " with status " + escapeHtml(notification.getStatus()) + " and description " + escapeHtml(notification.getDescription())
+ " Old Status was " + escapeHtml(notification.getOldStatus())
+ "</BODY></HTML>");

}
Expand All @@ -77,6 +77,16 @@ public void run() {

}

private static String escapeHtml(String input) {
if (input == null) {
return "";
}
return input
.replace("&", "&amp;")
.replace("<", "&lt;")
.replace(">", "&gt;");
}

public void sendResponse(int statusCode, String responseString) {

String statusLine = null;
Expand Down
Loading