Skip to content

TIS-827 Changed amount from double to Double in DecisionDetails #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gering112 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TIS-827 Changed amount from double to Double in DecisionDetails #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion riskified-sdk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.riskified</groupId>
<artifactId>riskified-sdk</artifactId>
<version>v2.15.0</version>
<version>v3.0.0</version>
<name>Riskified SDK</name>
<description>Riskified rest api SDK for java</description>
<url>https://www.riskified.com</url>
Expand Down
2 changes: 1 addition & 1 deletion riskified-sdk/src/main/java/com/riskified/RiskifiedClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,7 +1074,7 @@ private HttpPost createPostRequest(String url) {
postRequest.setHeader(HttpHeaders.ACCEPT, "application/vnd.riskified.com; version=2");
postRequest.setHeader(HttpHeaders.ACCEPT, "application/json");
postRequest.setHeader("X-RISKIFIED-SHOP-DOMAIN", shopUrl);
postRequest.setHeader("User-Agent","riskified_java_sdk/2.15.0"); // TODO: take the version automatically
postRequest.setHeader("User-Agent","riskified_java_sdk/3.0.0"); // TODO: take the version automatically
postRequest.setHeader("Version",versionHeaderValue);
return postRequest;
}
Expand Down
10 changes: 5 additions & 5 deletions .../java/com/riskified/TranStatusReason.java → ...java/com/riskified/TransStatusReason.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.riskified;

public enum TranStatusReason {
public enum TransStatusReason {
Zero_One("01"),
Zero_TWO("02"),
Zero_Three("03"),
Expand Down Expand Up @@ -33,14 +33,14 @@ public enum TranStatusReason {



private final String tranStatusReason;
private final String transStatusReason;

TranStatusReason(String tranStatusReason) {
this.tranStatusReason = tranStatusReason;
TransStatusReason(String transStatusReason) {
this.transStatusReason = transStatusReason;
}

public String getValue() {
return tranStatusReason;
return transStatusReason;
}

}
22 changes: 11 additions & 11 deletions riskified-sdk/src/main/java/com/riskified/models/AuthenticationResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import java.util.Date;

import com.riskified.TranStatusReason;
import com.riskified.TransStatusReason;
import com.riskified.TransStatus;
import com.riskified.validations.*;

Expand All @@ -11,8 +11,8 @@ public class AuthenticationResult implements IValidated {
private String eci;
private String cavv;
private Date createdAt;
private TransStatus tranStatus;
private TranStatusReason tranStatusReason;
private TransStatus transStatus;
private TransStatusReason transStatusReason;
private Boolean liabilityShift;
private Boolean three_d_challenge;
private Boolean tra_exemption;
Expand All @@ -23,21 +23,21 @@ public AuthenticationResult(String eci) {
this.eci = eci;
}

public TranStatusReason getTranStatusReason() {
return tranStatusReason;
public TransStatusReason getTransStatusReason() {
return transStatusReason;
}

public void setTranStatusReason(TranStatusReason tranStatusReason) {
this.tranStatusReason = tranStatusReason;
public void setTransStatusReason(TransStatusReason transStatusReason) {
this.transStatusReason = transStatusReason;
}


public TransStatus getTranStatus() {
return tranStatus;
public TransStatus getTransStatus() {
return transStatus;
}

public void setTranStatus(TransStatus transStatus) {
this.tranStatus = transStatus;
public void setTransStatus(TransStatus transStatus) {
this.transStatus = transStatus;
}


Expand Down
2 changes: 1 addition & 1 deletion riskified-sdk/src/main/java/com/riskified/models/DecisionDetails.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public class DecisionDetails implements IValidated {
private DecisionType externalStatus;
private String reason;
private Date decidedAt;
private double amount;
private Double amount;
private String currency;
private String notes;

Expand Down
4 changes: 4 additions & 0 deletions riskified-sdk/src/main/java/com/riskified/models/ResOrder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public class ResOrder {
private String action;
private Advice advice;
private RecoveryEligibility recoveryEligibility;
private Double riskScore;


public String getId() {
Expand Down Expand Up @@ -99,6 +100,9 @@ public void setAction(String action) {
public RecoveryEligibility getRecoveryEligibility(){return recoveryEligibility;}

public void setRecoveryEligibility(RecoveryEligibility recoveryEligibility){this.recoveryEligibility = recoveryEligibility;}

public void setRiskScore(Double riskScore){this.riskScore = riskScore;}
public Double getRiskScore(){return riskScore;}

public class Advice {

Expand Down