DEMO: brand-subtle color shift (validates Chromatic diffing)#2
Open
RisingOrange wants to merge 1 commit intovisual-regression-trialfrom
Open
DEMO: brand-subtle color shift (validates Chromatic diffing)#2RisingOrange wants to merge 1 commit intovisual-regression-trialfrom
RisingOrange wants to merge 1 commit intovisual-regression-trialfrom
Conversation
RisingOrange
force-pushed
the
visual-regression-demo-diff
branch
6 times, most recently
from
57c6c67 to
397e10e
Compare
Not for merge — this is a throwaway change to validate that the visual-diff pipeline surfaces real CSS changes in Chromatic's UI. Affects link color on every page that renders a link.
RisingOrange
force-pushed
the
visual-regression-demo-diff
branch
from
397e10e to
f263547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway stacked PR to validate that the visual-diff pipeline surfaces real CSS changes in Chromatic's UI. Not for merge.
Change:
--brand-subtleshifted from orange (hsl(32, 100%, 35%)) to blue (hsl(210, 100%, 45%)) in light mode. This variable is used for link color across the site, so Chromatic should detect diffs on essentially every page in the covered set.Expected: ~14 routes × 2 viewports = 28 snapshots, most showing a diff. Once validated, close this PR without merging.