feat: WeCom Stream Mode (WebSocket long-connection)#946
Conversation
jaberjaber23
left a comment
There was a problem hiding this comment.
LGTM. Legitimate WeCom Stream Mode channel adapter. Clean 822-line implementation with proper WebSocket protocol handling (subscribe, ping heartbeat, msg/event callbacks), message deduplication via ring-buffer cache, Zeroizing for secret, outbound message queue, and correct ChannelAdapter trait implementation. Config integration is clean. Please rebase on main.
|
This PR has merge conflicts. Please rebase onto the latest main branch and resolve conflicts so we can merge. |
|
Thanks @felix307253927 — WeCom stream mode via the official WebSocket endpoint ( Before re-review:
Happy to re-review once rebased. |
jaberjaber23
left a comment
There was a problem hiding this comment.
6 files including mcp.rs for what's titled WeCom Stream Mode. Why does the MCP runtime path change for a channel adapter? Please either remove that hunk or split it into its own PR with a clear explanation.
Also 40+ days old now and likely conflicts with main. Please rebase, drop the mcp.rs change unless it is genuinely required by the WeCom path (with rationale in the PR body), and we will re-review.
Extra scrutiny applies because of the cmd /C safe-path regression caught in your earlier PR #749. Clean focused submission is the path to merge.
Summary
Add WeCom Stream Mode (WebSocket long-connection)
Changes
Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity