Fix browser hand Python detection on modern Linux (python3 vs python)#393
Closed
cryptonahue wants to merge 1 commit intoRightNow-AI:mainfrom
Closed
Fix browser hand Python detection on modern Linux (python3 vs python)#393cryptonahue wants to merge 1 commit intoRightNow-AI:mainfrom
cryptonahue wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Modern Debian/Ubuntu systems (24.04+) only ship python3 as the binary name — python is not available by default. The browser hand dependency check was using check_value = "python" which always fails on these systems, blocking the hand installer even when Python 3 is properly installed. Changed check_value from "python" to "python3" to match the actual binary name on Linux. The install command (sudo apt install python3) was already correct.
Member
|
Already fixed on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pythonbinary to verify Python 3 is installedpython3—pythonis not available by defaultReproduction
python-is-python3package)✗ Python 3 must be installeddespite Python 3 being present at/usr/bin/python3Fix
Changed
check_value = "python"tocheck_value = "python3"inHAND.toml. The install command (sudo apt install python3) was already correct.Test plan
cargo test -p openfang-hands— 35 tests passcargo clippy -p openfang-hands -- -D warnings— zero warnings