Skip to content

Clean up the list of clients by removing dead/invalid connections. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielrampanelli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up the list of clients by removing dead/invalid connections. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Application/ServerApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,15 @@ public function addClient(Protocol\LivereloadProtocol $client)

public function removeClient(Protocol\LivereloadProtocol $client)
{
$this->clients = array_values(array_filter($this->clients, function($client) {
return !empty($client->app) && !empty($client->conn);
}));

$index = array_search($client, $this->clients, true);
if($index == false){
Copy link
Owner

@RickySu RickySu Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If $client is the first element of $this->clients (means $this->clients[0]), the result of $index is 0.
Using strong type compare ($index === false) is better.

Copy link
Author

@danielrampanelli danielrampanelli Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, that seems to be the cause all along. I've seen you have updated the master branch with this change, and everything seems to just run smoothly. Thanks!

return;
}

unset($this->clients[$index]);
}

Expand Down