fix: use dark background in all themes#14
Open
RickardHF wants to merge 1 commit into
Open
Conversation
Update light mode CSS variables to use the same dark palette as the default/dark theme, ensuring the background stays dark regardless of the user's prefers-color-scheme setting. Closes #13 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
RickardHF
commented
May 20, 2026
Owner
Author
RickardHF
left a comment
RickardHF
left a comment
There was a problem hiding this comment.
Review: ✅ Looks Good
Summary: This PR correctly addresses issue #13 by replacing the light-mode CSS variable values in globals.css with the same dark palette already defined in :root.
Correctness: All 11 overridden variables now exactly match their :root counterparts. The --btn-text value was already correct and is preserved.
Observations:
- The change is minimal and surgical — only values inside the
@media (prefers-color-scheme: light)block are updated. - The comment was updated to reflect the design intent, which is good documentation.
- Since the light-mode values now mirror
:root, the entire@mediablock could technically be removed. However, keeping it is reasonable as explicit documentation of the "always dark" intent. - No functional regressions expected — this is a CSS-only change.
No issues found. LGTM — ready to merge.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the light mode CSS variables in
globals.cssto use the same dark palette as the default/dark theme. This ensures the background stays dark regardless of the user'sprefers-color-schemesetting.Closes #13