Add customizable storage disk support#6
Closed
npostman wants to merge 8 commits intoRichardStyles:masterfrom
Closed
Add customizable storage disk support#6npostman wants to merge 8 commits intoRichardStyles:masterfrom
npostman wants to merge 8 commits intoRichardStyles:masterfrom
Conversation
- Update private key filename config variable - Remove default values, as that is handled in the config file
- Add config variable to specify the storage disk - Implement storage_path config variable - Updated storage_path config variable name to be more clear. Also fixes the untended effects for people who actually set this variabe (but never did anything) - Add test coverage for both
Author
|
@RichardStyles Any chance you could review and merge this PR? Thanks. |
|
@RichardStyles Same question as npostman :s |
|
@RichardStyles, let us know. Currently cannot use package with Vapor (AWS Lambda) as the key would just get lost. :) |
Owner
|
Trying to play catch up with these. Apologies for the delay - it's been a fun year. My initial thought, you can create your own handler class and set provided it follows the RsaKeyHandler implementation. But this PR would make it easier to manage storage - so will look at this as it makes sense to have. |
Author
|
Welcome back 😄 And thanks for having a look. |
|
@RichardStyles click merge |
|
At this point will consider package abandoned given the unwillingness of maintainer to communicate during a period of 3 years. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds a configurable disk name for storage.
Idea and most work credits go to @forxer. I made a small change to make it actually work, and added test support.
In the process I also made the store path config variable work.