Skip to content

WIP: network refactoring#32

Closed
damz wants to merge 1 commit intomainfrom
pr/network-refactoring
Closed

WIP: network refactoring#32
damz wants to merge 1 commit intomainfrom
pr/network-refactoring

Conversation

@damz
Copy link
Copy Markdown
Contributor

@damz damz commented Jan 14, 2023

Objectives

  • Support GSM modems
  • Support Ethernet featherwings
  • Support Wifi in AP mode

@damz damz force-pushed the pr/network-refactoring branch from b773b4e to c217cd3 Compare January 19, 2023 03:10
@damz damz force-pushed the pr/network-refactoring branch from c217cd3 to 7ad5d94 Compare January 19, 2023 03:11
@keenanjohnson
Copy link
Copy Markdown
Member

This looks awesome @damz ! It looks to me in a quick read like the connection type is driven by the configuration settings.

One additional thought / improvement I was considering.

Do you think it's possible / would it make sense to have some sort of auto connection hierarchy that would remove the need for the configuration depending on what settings are configured / what hardware is available? The benefit of this is that for users building the Frog kit with a cellular modem, they wouldn't have to use Curl / a command line tool to change the network config.

I am imagining for example the priority would be:

  1. Ethernet
  2. Wifi
  3. Cellular

So the algorithm in my head would be:

  • IF Ethernet hardware is installed
    • THEN set the config to ethernet
  • ELSE IF Wifi configuration (SSID and password) are set
    • THEN set config to WIFI
  • ELSE Then assume a cellular connection and set config to cellular

@keenanjohnson
Copy link
Copy Markdown
Member

@damz I am planning on taking this over. Was there any known outstanding work or issues when you left it?

@keenanjohnson keenanjohnson linked an issue Jun 15, 2023 that may be closed by this pull request
@keenanjohnson
Copy link
Copy Markdown
Member

Moving to a new PR so I can take this over: #39.

@damz if you have any memories of what the state of this was when you left it, that would be immensely helpful so I know where to start. Really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate Wi-Fi & Cellular Location Based Service (LBS)

2 participants