Skip to content

Confirm rate limit comment matches burst value (60)#38

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/adjust-limit-comment-in-rate-limit
Closed

Confirm rate limit comment matches burst value (60)#38
Copilot wants to merge 1 commit into
mainfrom
copilot/adjust-limit-comment-in-rate-limit

Conversation

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown

The comment added in PR #20 read // 60 requests/minute per key with a burst of 30 while the actual burst argument passed to ratelimit.New was 60 — a clear mismatch.

The comment has since been corrected on main to accurately reflect the configured values:

// 1 request/sec per key with a burst of 60; lazily evict keys after about 10-20 minutes of idleness.
limiter := ratelimit.New(rate.Every(time.Second), 60, 10*time.Minute)

All other references (README.md, internal/docs/openapi.yaml) already consistently state burst of 60.

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request
Copilot AI force-pushed the copilot/adjust-limit-comment-in-rate-limit branch from 2572df4 to 6637840 Compare June 1, 2026 23:58
Copilot AI changed the title [WIP] Fix comment mismatch in rate limit burst value Confirm rate limit comment matches burst value (60) Jun 1, 2026
Copilot AI requested a review from keenanjohnson June 1, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust limit Comment in Rate Limit

2 participants