Skip to content

feat(nodejs): propose working directory#3

Open
jplanckeel wants to merge 11 commits intoReyahSolutions:masterfrom
jplanckeel:patch-1
Open

feat(nodejs): propose working directory#3
jplanckeel wants to merge 11 commits intoReyahSolutions:masterfrom
jplanckeel:patch-1

Conversation

@jplanckeel
Copy link

we want use this action on monorepo with subfolder

we want use this action on monorepo with subfolder
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jplanckeel
❌ Jeremy PLANCKEEL


Jeremy PLANCKEEL seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@ArthurKnoep ArthurKnoep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thanks for your contribution and sorry for the delay I had a pretty busy week

Your PR seems fine, just few things to fix before I can accept it.

Also you'll need to sign the CLA, I know it's a pain but as we are a company we need to back up ourselves (rest assured that we will most likely never earn any money with this project 😆)

jplanckeel and others added 4 commits January 28, 2022 11:17
Co-authored-by: Arthur Knoepflin <arthur.knoepflin@epitech.eu>
Co-authored-by: Arthur Knoepflin <arthur.knoepflin@epitech.eu>
Co-authored-by: Arthur Knoepflin <arthur.knoepflin@epitech.eu>
Copy link
Member

@ArthurKnoep ArthurKnoep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@jplanckeel
Copy link
Author

Hi @ArthurKnoep can you merge this PR ?

@ArthurKnoep
Copy link
Member

It seems that you haven't signed the contributor license agreement, you can sign it there: https://cla-assistant.io/ReyahSolutions/matrix-git-generator?pullRequest=3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants