Skip to content

Mark constants translatable #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaroncocker wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mark constants translatable #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6caf97
Mark default drum and pattern constants as translatable (#113)
aaroncocker Dec 28, 2025
edb686b
Mark default drum and pattern constants as translatable (#113)
aaroncocker Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions io.github.revisto.drum-machine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,16 @@
"modules" : [
"python-dependencies.json",
{
"name": "blueprint-compiler",
"buildsystem": "meson",
"cleanup": ["*"],
"sources": [
"name" : "blueprint-compiler",
"buildsystem" : "meson",
"cleanup" : [
"*"
],
"sources" : [
Comment on lines -28 to +33
Copy link
Copy Markdown
Contributor

@yakushabb yakushabb Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for interrupting. I'm not the project's developer, but in general, please avoid changing unrelated files. It wastes developers' and maintainers' time.

{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/blueprint-compiler",
"tag": "0.18.0"
"type" : "git",
"url" : "https://gitlab.gnome.org/GNOME/blueprint-compiler",
"tag" : "0.18.0"
}
]
},
Expand All @@ -45,7 +47,13 @@
"type" : "dir",
"path" : "."
}
],
"config-opts" : [
"--libdir=lib"
]
}
]
],
"build-options" : {
"env" : { }
}
}
37 changes: 21 additions & 16 deletions src/config/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,32 @@
# SPDX-License-Identifier: GPL-3.0-or-later

from typing import List, Set, Tuple
from gettext import gettext as _

# Default drum part names shown in the UI
DEFAULT_DRUM_PARTS: List[str] = [
"kick",
"kick-2",
"kick-3",
"snare",
"snare-2",
"hihat",
"hihat-2",
"clap",
"tom",
"crash",
_("kick"),
_("kick-2"),
_("kick-3"),
_("snare"),
_("snare-2"),
_("hihat"),
_("hihat-2"),
_("clap"),
_("tom"),
_("crash"),
]

# Default rhythm pattern names shown in the UI
DEFAULT_PATTERNS: List[str] = [
"Shoot",
"Maybe Rock",
"Boom Boom",
"Night",
"Slow",
"Chill",
_("Shoot"),
_("Maybe Rock"),
_("Boom Boom"),
_("Night"),
_("Slow"),
_("Chill"),
]

NUM_TOGGLES: int = 16
GROUP_TOGGLE_COUNT: int = 4
DEFAULT_BPM: int = 120
Expand Down