Destroy ships when player is defeated #1883
Destroy ships when player is defeated #1883Flamefire wants to merge 15 commits intoReturn-To-The-Roots:masterfrom
Conversation
Unify uses of soldier checks in one place.
It is never used and can cause confusion. `nofPassiveWorker` should be used for transfers to a warehouse.
…ove not used code where goal is nullptr because this can never happen
When the "Collect" option in a warehouse for a job is set the actual job subclass will be created which expects its workplace as the goal, i.e. a `nobUsual` for most. In this situtation the goal is the warehouse to which the figure should go. So check that in `OrderJob` and create a `nofPassiveWorker` instead similar to the `Send` option handler.
This is run for every gameframe in "real mode" and required for some tests simulating e.g. a single step.
This is a corner case when destroying the harbor leads to defeat which leads to sinking ships potentially with wares to this building.
Flamefire
force-pushed
the
sinkShipsOnDefeat
branch
from
967fd01 to
c2f69f8
Compare
|
Juast asking - this is not an addon, is it? I'm actually not sure if it should or not. Also if it should depend on if a player is defeated with destroying buildings or without. Guess this is just always which should be fine I guess, although this might stop ongoing sea attacks opposed to a normal attack which would still be going on. |
|
This is not an addon. When a player is defeated (no more military, warehouses/HQs) or he surrenders his ships are destroyed/removed. I don't see any issue with that and it's what I got out of #183
For people etc. they will wander around and eventually die, so why not do the same for ships as everything else will be gone too. |
3 participants
As suggested in #183 ships will now be destroyed when a player is defeated or surrenders.
Requires: