Fix collection of jobs to warehouses#1882

Merged

Flow86 merged 9 commits intoReturn-To-The-Roots:masterfrom

Flamefire:sendCollectFix

Feb 7, 2026

Commits on Feb 2, 2026

Add `isSoldierJob` function
Flamefire
committed
Remove unused overload for figures with warehouse goal
Flamefire
committed
Add function to avoid code duplication

ottml
authored and
Flamefire
committed
Code review: Use consistent cast and parse argument as reference. Remove not used code where goal is nullptr because this can never happen

ottml
authored and
Flamefire
committed
Factor out check if a GOT is a storehouse/nobBaseWarehouse
Flamefire
committed
Fix collection of jobs to warehouses
Flamefire
committed
Pass `goal` by reference as it is always non-NULL
Flamefire
committed
Enhance doc for `checked_cast` and assert type requirements
Flamefire
committed
Also use references for non-NULL arguments in `GamePlayer`
Flamefire
committed