Fixed game crashing when game files failed to load (again)#41
Merged
Flamefire merged 1 commit intoReturn-To-The-Roots:masterfrom Jan 23, 2026
Merged
Fixed game crashing when game files failed to load (again)#41Flamefire merged 1 commit intoReturn-To-The-Roots:masterfrom
Flamefire merged 1 commit intoReturn-To-The-Roots:masterfrom
Conversation
Flamefire
added a commit
to Flamefire/s25client
that referenced
this pull request
Jan 23, 2026
Includes Return-To-The-Roots/languages#41 fixing a crash where the German translation was missing a format string. Adapt the test to catch this: If we don't "translate" something in the `en_GB` file it won't show up in the `.mo` file and won't be checked. As the test checks all translated strings (see the `continue`) anyways iterate over the translation file instead, backreferencing the "gold" entries.
Flow86
pushed a commit
to Return-To-The-Roots/s25client
that referenced
this pull request
Jan 23, 2026
Includes Return-To-The-Roots/languages#41 fixing a crash where the German translation was missing a format string. Adapt the test to catch this: If we don't "translate" something in the `en_GB` file it won't show up in the `.mo` file and won't be checked. As the test checks all translated strings (see the `continue`) anyways iterate over the translation file instead, backreferencing the "gold" entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has already been fixed in #38 but got overwritten by 5177b71
I don't know if this was a mistake but my game crashes without this change.