Open
Conversation
sergev
requested changes
Aug 31, 2024
Contributor
sergev
left a comment
sergev
left a comment
There was a problem hiding this comment.
This change does not make much sense. Please create sys/riscv directory and put RISC-V specific file io.h there.
Author
I am unable to create new folders from the github web interface. |
fixes error:
```
['riscv64-unknown-elf-gcc', '-march=rv32i', '-mabi=ilp32', '-c', '-mcmodel=medany', '-fomit-frame-pointer', '-ffunction-sections', '-ffreestanding', '-nostdlib', '-nostartfiles', '-nodefaultlibs', '-O0', '-g', '-o', '/tmp/subr_log.c.o', './sys/kernel/subr_log.c', '-I./include', '-DKERNEL']
./sys/kernel/subr_log.c:35:22: error: array type has incomplete element type 'struct devspec'
35 | const struct devspec logdevs[] = {
```
```
riscv64-unknown-elf-ld: /tmp/kern_sysctl.c.o: in function `fill_from_u':
/home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:753: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:757: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:759: undefined reference to `bdevsw'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:760: undefined reference to `u'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:773: undefined reference to `u'
riscv64-unknown-elf-ld: /tmp/kern_sysctl.c.o: in function `sysctl_doproc':
/home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:882: undefined reference to `copyout'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:886: undefined reference to `copyout'
Traceback (most recent call last):
File "/home/rap/cbacktick/retrobsd/retrobsd.py", line 59, in <module>
mkkernel()
File "/home/rap/cbacktick/retrobsd/retrobsd.py", line 56, in mkkernel
subprocess.check_call(cmd)
File "/usr/lib/python3.11/subprocess.py", line 413, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['riscv64-unknown-elf-ld', '-march=rv32', '-m', 'elf32lriscv', '-o', '/tmp/retrobsd.elf', '/tmp/vfs_vnops.c.o', '/tmp/tty.c.o', '/tmp/subr_prf.c.o', '/tmp/init_main.c.o', '/tmp/sys_pipe.c.o', '/tmp/kern_prot.c.o', '/tmp/exec_subr.c.o', '/tmp/kern_descrip.c.o', '/tmp/ufs_mount.c.o', '/tmp/ufs_dsort.c.o', '/tmp/init_sysent.c.o', '/tmp/sys_generic.c.o', '/tmp/exec_conf.c.o', '/tmp/ufs_inode.c.o', '/tmp/kern_glob.c.o', '/tmp/ufs_namei.c.o', '/tmp/vm_swp.c.o', '/tmp/kern_prot2.c.o', '/tmp/kern_sig2.c.o', '/tmp/exec_elf.c.o', '/tmp/sys_inode.c.o', '/tmp/vm_swap.c.o', '/tmp/tty_pty.c.o', '/tmp/kern_mman.c.o', '/tmp/kern_sig.c.o', '/tmp/syscalls.c.o', '/tmp/ufs_syscalls2.c.o', '/tmp/sys_process.c.o', '/tmp/kern_subr.c.o', '/tmp/ufs_syscalls.c.o', '/tmp/kern_synch.c.o', '/tmp/vm_sched.c.o', '/tmp/kern_clock.c.o', '/tmp/ufs_bio.c.o', '/tmp/ufs_alloc.c.o', '/tmp/ufs_subr.c.o', '/tmp/subr_rmap.c.o', '/tmp/kern_proc.c.o', '/tmp/tty_subr.c.o', '/tmp/kern_exec.c.o', '/tmp/exec_aout.c.o', '/tmp/ufs_bmap.c.o', '/tmp/kern_exit.c.o', '/tmp/exec_script.c.o', '/tmp/kern_fork.c.o', '/tmp/subr_log.c.o', '/tmp/kern_time.c.o', '/tmp/tty_tty.c.o', '/tmp/ufs_fio.c.o', '/tmp/kern_resource.c.o', '/tmp/kern_sysctl.c.o']' returned non-zero exit status 1.
```
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:616: undefined reference to `file'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:632: undefined reference to `file'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:640: undefined reference to `copyout'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:641: undefined reference to `copyout'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:632: undefined reference to `file'
riscv64-unknown-elf-ld: /tmp/kern_sysctl.c.o: in function `sysctl_inode':
/home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:687: undefined reference to `inode'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:687: undefined reference to `inode'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:698: undefined reference to `inode'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:706: undefined reference to `copyout'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:707: undefined reference to `copyout'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:698: undefined reference to `inode'
riscv64-unknown-elf-ld: /tmp/kern_sysctl.c.o: in function `fill_from_u':
/home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:753: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:757: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /tmp/kern_sysctl.c.o: in function `sysctl_doproc':
/home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:881: undefined reference to `copyout'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/kernel/kern_sysctl.c:885: undefined reference to `copyout'
riscv64-unknown-elf-ld: /tmp/_riscv_devsw.o:(.rodata+0xdc): undefined reference to `mmrw'
riscv64-unknown-elf-ld: /tmp/_riscv_devsw.o:(.rodata+0xe0): undefined reference to `mmrw'
riscv64-unknown-elf-ld: /tmp/_riscv_swap.o: in function `swopen':
/home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:37: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:37: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /tmp/_riscv_swap.o: in function `swclose':
/home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:49: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:49: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /tmp/_riscv_swap.o: in function `swcioctl':
/home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:193: undefined reference to `swapmap'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:195: undefined reference to `swapmap'
riscv64-unknown-elf-ld: /tmp/_riscv_swap.o: in function `swstrategy':
/home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:224: undefined reference to `swapdev'
riscv64-unknown-elf-ld: /home/rap/cbacktick/retrobsd/./sys/pic32/swap.c:225: undefined reference to `swapdev'
Traceback (most recent call last):
File "/home/rap/cbacktick/retrobsd/retrobsd.py", line 117, in <module>
mkkernel()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.