fix potential memory leaks and undefined behavior#1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The c
isXfunctions (likeisalpha) have undefined behavior for unicode characters.iswXfunctions are provided, but the default implementation of those is just to check ranges. Since range checks can be constexpr, and I'm likely to forget about theiswXfunctions, I've added helper functions inra::util::Stringfor theisXfunctions. This eliminates the undefined behavior, and potentially encourages some compiler optimization.Some missing
rc_api_destroyfunction calls were added, which would eliminate memory leaks in some paths.Ensures an ImageBinding waiting for an image isn't called if the image arrives after the ImageBinding is destroyed.
Fixes a potential issue with the sensitive parameter logging code if the
r=parameter is not the first parameter in the query params.