Skip to content

refactor(build): remove BepisLoader.runtimeconfig.json overwrites #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hazre wants to merge 1 commit into from
Closed

refactor(build): remove BepisLoader.runtimeconfig.json overwrites #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions Runtimes/NET/BepisLoader/LinuxBootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,25 +82,6 @@ main()
chmod +x "$DOTNET_EXECUTABLE"


# Replace Windows runtime config with Linux runtime config for BepisLoader
if [ -f "./BepisLoader.runtimeconfig.json" ]; then
cat > "./BepisLoader.runtimeconfig.json" <<-'EOF'
{
"runtimeOptions": {
"tfm": "net10.0",
"framework": {
"name": "Microsoft.NETCore.App",
"version": "10.0.0"
},
"configProperties": {
"System.Reflection.Metadata.MetadataUpdater.IsSupported": false,
"System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false
}
}
}
EOF
fi

echo "Parsing hookfxr parameters"
HOOKFXR_STATUS=""
TARGET_ASSEMBLY=""
Expand Down
33 changes: 0 additions & 33 deletions build/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,39 +467,6 @@ public override void Run(BuildContext ctx)
ctx.Log.Warning($"hookfxr cache directory not found: {hookfxrPath}");
}

// Replace contents of BepisLoader.runtimeconfig.json with the proper framework configuration for windows
var runtimeConfigPath = targetDir.CombineWithFilePath("BepisLoader.runtimeconfig.json");
if (ctx.FileExists(runtimeConfigPath))
{
var runtimeConfig = """
{
"runtimeOptions": {
"tfm": "net10.0",
"frameworks": [
{
"name": "Microsoft.NETCore.App",
"version": "10.0.0"
},
{
"name": "Microsoft.WindowsDesktop.App",
"version": "10.0.0"
}
],
"configProperties": {
"System.Reflection.Metadata.MetadataUpdater.IsSupported": false,
"System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false
}
}
}
""";
System.IO.File.WriteAllText(runtimeConfigPath.FullPath, runtimeConfig);
ctx.Log.Information("Updated BepisLoader.runtimeconfig.json with proper framework configuration");
}
else
{
ctx.Log.Warning($"BepisLoader.runtimeconfig.json not found at: {runtimeConfigPath}");
}

// Copy icon.ico from BepisLoader project directory to BepInEx folder
var iconPath = ctx.RootDirectory.CombineWithFilePath("Runtimes/NET/BepisLoader/icon.ico");
if (ctx.FileExists(iconPath))
Expand Down
Loading