Skip to content

Bump rubyzip to support 3.x and widen addressable range #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbacall merged 1 commit into from
May 7, 2026
Merged

Bump rubyzip to support 3.x and widen addressable range #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3']
fail-fast: false
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion lib/ro_crate/writer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def write(dir, overwrite: true, skip_preview: false)
# @param destination [String, ::File] The destination where to write the RO-Crate zip.
# @param skip_preview [Boolean] Whether or not to skip generation of the RO-Crate preview HTML file.
def write_zip(destination, skip_preview: false)
Zip::File.open(destination, Zip::File::CREATE) do |zip|
Zip::File.open(destination, create: true) do |zip|
@crate.payload.each do |path, entry|
next if entry.directory?
next if skip_preview && entry&.source.is_a?(ROCrate::PreviewGenerator)
Expand Down
4 changes: 2 additions & 2 deletions ro_crate.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ Gem::Specification.new do |s|
s.homepage = 'https://github.com/ResearchObject/ro-crate-ruby'
s.require_paths = ['lib']
s.licenses = ['MIT']
s.add_runtime_dependency 'addressable', '>= 2.7', '< 2.9'
s.add_runtime_dependency 'rubyzip', '~> 2.0.0'
s.add_runtime_dependency 'addressable', '>= 2.7', '< 3'
s.add_runtime_dependency 'rubyzip', '>= 2.3', '< 4'
s.add_development_dependency 'rake', '~> 13.0.0'
s.add_development_dependency 'test-unit', '~> 3.5.3'
s.add_development_dependency 'simplecov', '~> 0.21.2'
Expand Down
Loading