Skip to content

Conversation

@alexandre-abrioux-rf
Copy link
Contributor

@alexandre-abrioux-rf alexandre-abrioux-rf commented Dec 15, 2025

Description of the changes

Bump Starknet SDK to include the fix starknet-io/starknet.js#1514

Summary by CodeRabbit

  • Chores
    • Updated Starknet dependency to version 9.2.1

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Walkthrough

Updated the Starknet dependency version from 7.6.4 to 9.2.1 in the currency package configuration. This is a minor version update affecting the declared public dependency in packages/currency/package.json.

Changes

Cohort / File(s) Change Summary
Dependency Update
packages/currency/package.json
Updated starknet dependency from 7.6.4 to 9.2.1

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify Starknet v9.2.1 compatibility and check for breaking changes between 7.6.4 and 9.2.1
  • Confirm no additional transitive dependency conflicts introduced by the upgrade

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: bump starknet' is concise and directly describes the main change of updating the Starknet dependency version.
Description check ✅ Passed The description includes the required section and provides context about why the bump is needed, referencing a specific fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-starknet

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04115a3 and da385a4.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • packages/currency/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

**/*: - Only comment on issues that would block merging — ignore minor or stylistic concerns.

  • Restrict feedback to errors, security risks, or functionality-breaking problems.
  • Do not post comments on code style, formatting, or non-critical improvements.
  • Keep reviews short: flag only issues that make the PR unsafe to merge.
  • Limit review comments to 3–5 items maximum, unless additional blockers exist.
  • Group similar issues into a single comment instead of posting multiple notes.
  • Skip repetition — if a pattern repeats, mention it once at a summary level only.
  • Do not add general suggestions; focus strictly on merge-blocking concerns.
  • If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
  • Avoid line-by-line commentary unless it highlights a critical bug or security hole.
  • Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
  • Ignore minor optimization opportunities — focus solely on correctness and safety.
  • Provide a top-level summary of critical blockers rather than detailed per-line notes.
  • Comment only when the issue must be resolved before merge — otherwise, remain silent.
  • When in doubt, err on the side of fewer comments — brevity and blocking issues only.
  • Avoid posting any refactoring issues

Files:

  • packages/currency/package.json
🧠 Learnings (4)
📓 Common learnings
Learnt from: giorgi-kiknavelidze
Repo: RequestNetwork/requestNetwork PR: 1482
File: packages/usage-examples/package.json:42-42
Timestamp: 2024-11-04T12:18:18.615Z
Learning: In the RequestNetwork project, the `dotenv` package version is maintained at `10.0.0` across packages, including `packages/smart-contracts/package.json`, to ensure consistency.
📚 Learning: 2024-11-04T12:18:18.615Z
Learnt from: giorgi-kiknavelidze
Repo: RequestNetwork/requestNetwork PR: 1482
File: packages/usage-examples/package.json:42-42
Timestamp: 2024-11-04T12:18:18.615Z
Learning: In the RequestNetwork project, the `dotenv` package version is maintained at `10.0.0` across packages, including `packages/smart-contracts/package.json`, to ensure consistency.

Applied to files:

  • packages/currency/package.json
📚 Learning: 2024-11-18T12:33:47.986Z
Learnt from: rodrigopavezi
Repo: RequestNetwork/requestNetwork PR: 1475
File: packages/epk-cypher/package.json:49-67
Timestamp: 2024-11-18T12:33:47.986Z
Learning: In the `packages/epk-cypher/package.json` file, avoid suggesting updates to development dependencies unless essential, as the maintainer prefers to prevent potential instability.

Applied to files:

  • packages/currency/package.json
📚 Learning: 2024-11-04T12:18:12.407Z
Learnt from: giorgi-kiknavelidze
Repo: RequestNetwork/requestNetwork PR: 1482
File: packages/payment-processor/package.json:42-42
Timestamp: 2024-11-04T12:18:12.407Z
Learning: In the RequestNetwork project, dependencies in `package.json` files are pinned to exact versions to prevent unexpected breakages with examples. Therefore, caret version ranges (e.g., `^0.0.167`) should not be suggested.

Applied to files:

  • packages/currency/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-and-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 15, 2025

Greptile Overview

Greptile Summary

Bumped starknet dependency from 7.6.4 to 9.2.1 to include an upstream bug fix from starknet.js PR #1514.

  • Updated starknet package version in packages/currency/package.json
  • Lock file automatically updated with new transitive dependencies including @wallet-standard/base, @wallet-standard/features, ox, and updated versions of @noble/curves, @noble/hashes, and @scure/base
  • The package is used for Starknet address validation via validateAndParseAddress() function in the currency manager

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • This is a straightforward dependency bump to incorporate an upstream bug fix. The major version jump (7.6.4 to 9.2.1) is significant, but the package usage is limited to a single function (validateAndParseAddress) for address validation, reducing the surface area for breaking changes. The dependency update follows standard package management practices with proper lock file updates.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/currency/package.json 5/5 Bumped starknet dependency from 7.6.4 to 9.2.1 to include upstream bug fix
yarn.lock 5/5 Updated lock file reflecting starknet 9.2.1 and its transitive dependencies

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Pkg as packages/currency
    participant SN as starknet.js Library
    
    Dev->>PM: Update starknet dependency to 9.2.1
    PM->>Pkg: Update package.json dependency version
    PM->>PM: Resolve dependency tree
    PM->>SN: Fetch starknet@9.2.1 and dependencies
    Note over SN: Includes fix from PR #1514
    SN-->>PM: Return updated package and transitive deps
    PM->>PM: Update yarn.lock with resolved versions
    Note over PM: New deps: @wallet-standard/*, ox, etc.
    PM-->>Dev: Dependencies updated successfully
    
    Note over Pkg,SN: validateAndParseAddress() now includes bug fix
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@alexandre-abrioux-rf alexandre-abrioux-rf merged commit 817bff3 into master Dec 16, 2025
16 checks passed
@alexandre-abrioux-rf alexandre-abrioux-rf deleted the bump-starknet branch December 16, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants