Skip to content

Update SwiftRestModel.swift #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AbbyJanke wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update SwiftRestModel.swift #11

AbbyJanke wants to merge 1 commit into from

Conversation

@AbbyJanke
Copy link

@AbbyJanke AbbyJanke commented Apr 18, 2016

SwiftyJSON has renamed isExists() to just exists() for better readability:

SwiftyJSON/SwiftyJSON#457

@abbylynn
Update SwiftRestModel.swift
9b52559 
Change isExists() to exists() for SwiftyJSON, changed here: https://github.com/SwiftyJSON/SwiftyJSON/pull/457/files
@AbbyJanke AbbyJanke mentioned this pull request Apr 18, 2016
Closed
@jurajhilje
Copy link
Contributor

jurajhilje commented Apr 19, 2016

Thanks for your PR!
It's a bit odd that they have broke public API from 2.3.2 to 2.3.3.

Please update Podfile also, to make sure exists() method is available in SwiftyJSON. Tests are failing for this PR because of SwiftyJSON version:

Testing failed:
    Value of type 'JSON' has no member 'exists'
** TEST FAILED **

@jurajhilje jurajhilje self-assigned this Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jurajhilje jurajhilje

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbbyJanke @jurajhilje @abbylynn