Open
Conversation
VelvetToroyashi
approved these changes
Nov 3, 2024
Contributor
VelvetToroyashi
left a comment
VelvetToroyashi
left a comment
There was a problem hiding this comment.
Needs to be updated for 'recent' Remora changes to caching, but looks good
Also unsure how this has gone without review up to this point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements simple scoping for the cache library in order to keep data belonging to different tokens separate.
In its current state, it is not a complete implementation since tokens provided via customizations onto single REST requests will not be picked up, and that mechanism may need some more in-depth changes. Consider this a design suggestion out for comments.
Fixes #257.