feat(savings_goals): add cursor pagination for owner goal listing#598
Merged
Baskarayelu merged 2 commits intoApr 27, 2026
Merged
Conversation
Add get_goals_for_owner(owner, cursor, limit) as a public contract method with deterministic cursor-based pagination backed by the owner-scoped goal ID index. Includes 13 comprehensive pagination tests covering limit clamping, full iteration, owner isolation, cross-owner cursor rejection, and edge cases. Also fixes pre-existing build issues: duplicate proptest key in remittance_split/Cargo.toml, String::from_slice type mismatch in tag validation, Val PartialEq errors in event_test.rs, and mismatched create_goal argument in stress_test_large_amounts.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add get_goals_for_owner(owner, cursor, limit) as a public contract method with deterministic cursor-based pagination backed by the owner-scoped goal ID index. Includes 13 comprehensive pagination tests covering limit clamping, full iteration, owner isolation, cross-owner cursor rejection, and edge cases.
Also fixes pre-existing build issues: duplicate proptest key in remittance_split/Cargo.toml, String::from_slice type mismatch in tag validation, Val PartialEq errors in event_test.rs, and mismatched create_goal argument in stress_test_large_amounts.rs.
Closes #530