Fix/hit 260 actions column too large in grid widgets#71
Open
NathanHGit wants to merge 1 commit intonext-oortfrom
Open
Fix/hit 260 actions column too large in grid widgets#71NathanHGit wants to merge 1 commit intonext-oortfrom
NathanHGit wants to merge 1 commit intonext-oortfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In grid widgets, the last column is dedicated to actions if there are any. Each cell can contain the dropdown list of actions and another icon if the line is being updated. The default column width had been set too fit these two elements, but the second icon is not always visible. The logic already handles size changes when showing or hiding icons, but the default value was too large. I configured it to be the icon width plus the padding. Since the column doesn't have a name by default, if no records are displayed, then an empty box is there in the table head. It could be remove if necessary.
Useful links
Type of change
How Has This Been Tested?
I created a new layout for a resource and a new dashboard with a grid widget. I verified the width of the last column.
Screenshots
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145