Skip to content

Fix/hit 260 actions column too large in grid widgets#71

Open
NathanHGit wants to merge 1 commit intonext-oortfrom
fix/HIT-260-actions-column-too-large-in-grid-widgets
Open

Fix/hit 260 actions column too large in grid widgets#71
NathanHGit wants to merge 1 commit intonext-oortfrom
fix/HIT-260-actions-column-too-large-in-grid-widgets

Conversation

@NathanHGit
Copy link
Contributor

Description

In grid widgets, the last column is dedicated to actions if there are any. Each cell can contain the dropdown list of actions and another icon if the line is being updated. The default column width had been set too fit these two elements, but the second icon is not always visible. The logic already handles size changes when showing or hiding icons, but the default value was too large. I configured it to be the icon width plus the padding. Since the column doesn't have a name by default, if no records are displayed, then an empty box is there in the table head. It could be remove if necessary.

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I created a new layout for a resource and a new dashboard with a grid widget. I verified the width of the last column.

Screenshots

peek

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@NathanHGit NathanHGit self-assigned this Mar 12, 2024
@NathanHGit NathanHGit added the bug Something isn't working label Mar 12, 2024
@NathanHGit NathanHGit requested a review from a team March 12, 2024 14:13
@NathanHGit NathanHGit marked this pull request as ready for review March 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant