[HIT-378] Display issue with forms in workflows#119
Open
brunotannus wants to merge 2 commits intonext-oortfrom
Open
[HIT-378] Display issue with forms in workflows#119brunotannus wants to merge 2 commits intonext-oortfrom
brunotannus wants to merge 2 commits intonext-oortfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the issue has to do with the structure of the rendered dom when there is a workflow. we already have this in the code that works for non-workflow form dashboards in sidenav-container.html:
[ngClass]="{ 'pb-[64px]': fixedWrapperActionExist }"which adds this padding to the content wrapper of id appPageContainer, but this content wrapper is only a direct parent of the form app when its not a workflow.
when it is a workflow, appPageContainer renders an app-workflow which then renders the app-form, so we need to add those classes to app-workflow as well, including pb-[64px] when there is a fixed action bar.
i moved the wrapper classes to a function and added them to app-workflow when suitable. the only thing is i have no idea why this bug doesnt occur on back-office, but this correction doesnt seem to affect it
Useful links
Type of change
Screenshots
Checklist: