Skip to content

[HIT-378] Display issue with forms in workflows#119

Open
brunotannus wants to merge 2 commits intonext-oortfrom
HIT-378-display-issue-with-forms-in-workflows
Open

[HIT-378] Display issue with forms in workflows#119
brunotannus wants to merge 2 commits intonext-oortfrom
HIT-378-display-issue-with-forms-in-workflows

Conversation

@brunotannus
Copy link
Contributor

Description

the issue has to do with the structure of the rendered dom when there is a workflow. we already have this in the code that works for non-workflow form dashboards in sidenav-container.html:
[ngClass]="{ 'pb-[64px]': fixedWrapperActionExist }"
which adds this padding to the content wrapper of id appPageContainer, but this content wrapper is only a direct parent of the form app when its not a workflow.
when it is a workflow, appPageContainer renders an app-workflow which then renders the app-form, so we need to add those classes to app-workflow as well, including pb-[64px] when there is a fixed action bar.
i moved the wrapper classes to a function and added them to app-workflow when suitable. the only thing is i have no idea why this bug doesnt occur on back-office, but this correction doesnt seem to affect it

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

image

Checklist:

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings

@brunotannus brunotannus added the bug Something isn't working label Sep 19, 2024
@brunotannus brunotannus requested a review from a team September 19, 2024 16:01
@brunotannus brunotannus self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant