Skip to content

Fix need to rotate android device to landscape to scan 1D barcodes, also fix focus and auto focus not being implemented #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Captnwalker1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix need to rotate android device to landscape to scan 1D barcodes, also fix focus and auto focus not being implemented #52

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
910e35d
Fix needed to rotate device to landscape to scan 1D barcodes
chris-walker-32341 Sep 19, 2022
cc715e5
Implement AutoFocus via Timer, and tap to focus
chris-walker-32341 Sep 23, 2022
e8386ac
Undo csproj and MainPage.xaml changes
chris-walker-32341 Sep 23, 2022
d6eb72e
MainPage.xaml.cs changes
chris-walker-32341 Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 79 additions & 4 deletions ZXing.Net.MAUI/Platforms/Android/CameraManager.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,12 @@ internal partial class CameraManager
ProcessCameraProvider cameraProvider;
ICamera camera;

Timer timer;

public NativePlatformCameraPreviewView CreateNativeView()
{
previewView = new PreviewView(Context.Context);
cameraExecutor = Executors.NewSingleThreadExecutor();
cameraExecutor = Executors.NewSingleThreadExecutor();

return previewView;
}
Expand All @@ -63,6 +65,7 @@ public void Connect()
// Frame by frame analyze
imageAnalyzer = new ImageAnalysis.Builder()
.SetDefaultResolution(new Android.Util.Size(640, 480))
.SetOutputImageRotationEnabled(true)
Copy link

@Ghostbird Ghostbird Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be set based on some input?

I don't want it to auto-rotate if I initialise this:

          new CameraBarcodeReaderView
          {
            Options = new BarcodeReaderOptions
            {
              AutoRotate = false,
              Multiple = false,
            }
          }

.SetBackpressureStrategy(ImageAnalysis.StrategyKeepOnlyLatest)
.Build();

Expand All @@ -71,9 +74,64 @@ public void Connect()

UpdateCamera();

}), ContextCompat.GetMainExecutor(Context.Context)); //GetMainExecutor: returns an Executor that runs on the main thread.
AutoFocus();
setupAutoFocusTimer();
Copy link

@Ghostbird Ghostbird Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it adds a continuous autofocus that's never canceled, even when you explicitly call one of the other functions.

((View)previewView.Parent).SetOnTouchListener(new TapFocusTouchListener(this));


}), ContextCompat.GetMainExecutor(Context.Context)); //GetMainExecutor: returns an Executor that runs on the main thread.
}

private class TapFocusTouchListener : Java.Lang.Object, View.IOnTouchListener {

private CameraManager cameraManager;

public TapFocusTouchListener(CameraManager cameraManager)
{
this.cameraManager = cameraManager;
}

public bool OnTouch(View v, MotionEvent e)
{

if (e.Action == MotionEventActions.Down)
{
Point point = new Point(((int)e.GetX()), ((int)e.GetY()));
cameraManager.Focus(point);
return true;
}
return false;
}
}

private void setupAutoFocusTimer()
{
if(timer != null)
{
timer.Cancel();
timer.Dispose();
timer = null;
}
timer = new Timer();
var task = new AFTimerTask(this);
timer.ScheduleAtFixedRate(task, 5000, 5000);
}

private class AFTimerTask : TimerTask
{
private CameraManager cameraManager;

public AFTimerTask(CameraManager manager)
{
this.cameraManager = manager;
}

public override void Run()
{
cameraManager.AutoFocus();
}
}

public void Disconnect()
{ }

Expand Down Expand Up @@ -110,13 +168,30 @@ public void UpdateTorch(bool on)

public void Focus(Point point)
{
camera?.CameraControl?.CancelFocusAndMetering();

}
var factory = new SurfaceOrientedMeteringPointFactory(previewView.LayoutParameters.Width, previewView.LayoutParameters.Height);
var fpoint = factory.CreatePoint(point.X, point.Y);
var action = new FocusMeteringAction.Builder(fpoint, FocusMeteringAction.FlagAf)
.DisableAutoCancel()
.Build();

camera?.CameraControl?.StartFocusAndMetering(action);

}

public void AutoFocus()
{
camera?.CameraControl?.CancelFocusAndMetering();
var factory = new SurfaceOrientedMeteringPointFactory(1f, 1f);
var fpoint = factory.CreatePoint(.5f, .5f);
var action = new FocusMeteringAction.Builder(fpoint,FocusMeteringAction.FlagAf)
//.DisableAutoCancel()
Copy link

@Ghostbird Ghostbird Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either remove this or uncomment it.

.Build();

}
camera?.CameraControl?.StartFocusAndMetering(action);

}

public void Dispose()
{
Expand Down