Merged
Conversation
bhuvan94
changed the title
Redth
approved these changes
Oct 18, 2022
Contributor
|
One issue I found with this fix is that it updates appropriately for the device orientation but doesn't account for the application orientation which could be different. E.g. The device is held in portrait when the scan starts but the application only supports landscape will lock the camera view in portrait thus being offset by 90 degrees. It also doesn't re-apply the layout when the device orientation changes. E.g. Change from landscape left to landscape right keeps the camera view in landscape left, thus resulting in the camera being upside down. I've created pull request #186 with help from a coworker to handle these two scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for iOS camera orientation issue (#40)