Skip to content

Comments

Add AssumeGS1 flag to barcode reader options#294

Merged
jfversluis merged 2 commits intoRedth:mainfrom
tekemi:allow_gs1
Feb 5, 2026
Merged

Add AssumeGS1 flag to barcode reader options#294
jfversluis merged 2 commits intoRedth:mainfrom
tekemi:allow_gs1

Conversation

@tekemi
Copy link
Contributor

@tekemi tekemi commented Feb 5, 2026

This PR adds a flag to BarcodeReaderOptions in order to enable the AssumeGS1 setting.
Some barcodes are not scanned properly without the AssumeGS1 option, so this option is now configurable.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the AssumeGS1 barcode scanning option to the ZXing.Net.MAUI library. The AssumeGS1 flag enables proper scanning of GS1-formatted barcodes that may not be detected correctly without this setting.

Changes:

  • Added AssumeGS1 boolean property to BarcodeReaderOptions class
  • Configured the underlying ZXing reader to use the AssumeGS1 option when set

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ZXing.Net.MAUI/BarcodeScannerOptions.cs Added new AssumeGS1 boolean property to the BarcodeReaderOptions record with implicit false default, following the same pattern as other boolean options
ZXing.Net.MAUI/ZXingBarcodeReader.cs Added assignment of AssumeGS1 option from the MAUI options to the underlying zxingReader configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jfversluis jfversluis merged commit 708e35b into Redth:main Feb 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants