Skip to content

Conversation

@LightOfHeaven1994
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 commented Mar 28, 2023

Added Calendar month here with basic methods we need.
https://www.patternfly.org/v4/components/calendar-month/

image

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the add-calendarmonth-widget branch 2 times, most recently from 2caa680 to 962ccb7 Compare March 29, 2023 07:48
Copy link
Member

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LightOfHeaven1994 for awesome work 👍

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the add-calendarmonth-widget branch from 962ccb7 to ca6a863 Compare March 31, 2023 11:59
@digitronik
Copy link
Member

some testing/test_calendarmonth.py tests are failing please take a look.

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the add-calendarmonth-widget branch from ca6a863 to 58b7f38 Compare April 3, 2023 14:14
@LightOfHeaven1994 LightOfHeaven1994 marked this pull request as draft April 3, 2023 14:14
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the add-calendarmonth-widget branch 2 times, most recently from b426628 to c0fbf86 Compare April 4, 2023 10:36
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the add-calendarmonth-widget branch from c0fbf86 to 00f43f0 Compare April 4, 2023 10:45
@LightOfHeaven1994
Copy link
Collaborator Author

@digitronik tests fixed except OUIA tests. I'm going to fix all tests here #173 but it will take some time (we depend here on PF team if they are going to merge my PR to set some OUIA IDs or I will need to change these tests)

@LightOfHeaven1994 LightOfHeaven1994 marked this pull request as ready for review April 5, 2023 06:52
Copy link
Member

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@digitronik digitronik merged commit 62a853a into RedHatQE:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants