IUO: multiarch automation#4988
Conversation
|
Warning Review limit reached
More reviews will be available in 57 minutes and 59 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (24)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4988 +/- ##
==========================================
- Coverage 98.67% 98.66% -0.02%
==========================================
Files 25 25
Lines 2487 2465 -22
==========================================
- Hits 2454 2432 -22
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-2
requested review from
OhadRevah,
geetikakay and
rlobillo
openshift-virtualization-qe-bot-2
requested review from
dshchedr,
rnetser and
vsibirsk
| for ds_name in default_common_templates_related_resources[DataSource.kind]: | ||
| data_source = DataSource( | ||
| name=ds_name, | ||
| namespace=golden_images_namespace.name, | ||
| client=admin_client, | ||
| ) | ||
| source = data_source.instance.spec.source | ||
| assert source.get("pvc") or source.get("snapshot"), ( | ||
| f"DataSource {ds_name} does not reference a pvc/snapshot source: {source}" | ||
| ) |
| for ds_name in base_ds_names: | ||
| data_source = DataSource( | ||
| name=ds_name, | ||
| namespace=golden_images_namespace.name, | ||
| client=admin_client, | ||
| ) | ||
| expected_arch_ds_prefix = f"{ds_name}-{control_plane_architecture}" | ||
| assert data_source.source.name.startswith(expected_arch_ds_prefix), ( | ||
| f"DataSource {ds_name} does not reference a control-plane " | ||
| f"architecture-specific DataSource (expected prefix: {expected_arch_ds_prefix}). " | ||
| f"Actual source: {data_source.source.name}" | ||
| ) |
There was a problem hiding this comment.
Also here, why not using subtests?
hmeir
force-pushed
the
iuo-multiarch-automation-v2
branch
from
b24996b to
38033b9
Compare
|
Clean rebase detected — no code changes compared to previous head ( |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Store cpu_arch as list in py_config for multi-arch runs. Fix schedulable_nodes to normalize cpu_arch to list and use 'in' membership check. Update cluster info log to handle list cpu_arch display. Signed-off-by: Harel Meir <hmeir@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Move validate_metrics_value from tests/observability/utils.py to utilities/monitoring.py for cross-directory reuse. Accept str|int expected_value (int 0 for absent metrics). Add unit tests. Update all observability callers to import from new location. Signed-off-by: Harel Meir <hmeir@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Store cpu_arch as list in py_config for multi-arch runs. Fix schedulable_nodes to normalize cpu_arch to list and use 'in' membership check. Update cluster info log to handle list cpu_arch display. Signed-off-by: Harel Meir <hmeir@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Harel Meir <hmeir@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
hmeir
force-pushed
the
iuo-multiarch-automation-v2
branch
from
38033b9 to
b8e59ae
Compare
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #5012. Overlapping filestests/observability/metrics/test_general_metrics.py |
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #4934. Overlapping filestests/conftest.py |
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #4954. Overlapping filesconftest.py |
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #4985. Overlapping filestests/conftest.py |
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #5086. Overlapping filesconftest.py |
5 participants
What this PR does / why we need it:
Implement multiarch golden images test automation with 8 tests across
3 classes, verifying the enableMultiArchBootImageImport HCO feature
gate behavior:
verifies no arch-specific resources exist and metrics report correctly
when the feature gate is disabled
verifies arch-specific DataImportCrons/DataSources are created and
pointer DataSources reference control-plane architecture
verifies misconfiguration metrics for annotation issues
Key design:
default_common_templates_related_resourceschecks HCO feature gateto return arch-specific or base resource names per kind
worker_architecturesderived fromschedulable_nodes_MULTIARCH_MANAGED_CRS = [SSP, KubeVirt, CDI]single_arch_node_placementwith workloads-only placementSTP: https://github.com/RedHatQE/openshift-virtualization-tests-design-docs/blob/main/stps/sig-iuo/multiarch_arm_support.md
Which issue(s) this PR fixes:
Special notes for reviewer:
Depends on PR #4972 and PR #4987 — merge those first.
CNV-15977 DataSource subtest quarantined via is_jira_open("CNV-68996").
update_hco_templates_spec fixed to append templates instead of replacing.
jira-ticket:
https://redhat.atlassian.net/browse/CNV-80548